Skip to content

refactor(harness): delete retired server graph topology (SAP-3091) - #912

Open
ynadge wants to merge 9 commits into
yashnadge/sap-3091-remove-server-graph-runtimefrom
yashnadge/sap-3091-delete-server-graph-topology
Open

refactor(harness): delete retired server graph topology (SAP-3091)#912
ynadge wants to merge 9 commits into
yashnadge/sap-3091-remove-server-graph-runtimefrom
yashnadge/sap-3091-delete-server-graph-topology

Conversation

@ynadge

@ynadge ynadge commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Primary change type

  • Bug fix
  • Documentation
  • Feature
  • Tests
  • Dependency update
  • Maintenance or refactor

Problem and motivation

The retired server graph engine, snapshot store, graph-only inventory/invocation lifecycle and contracts remained as orphaned source after composition removal.

Summary and scope

Delete those modules and their topology-only tests/fixtures. Remove the retired bus contract and filter unsupported events at the browser transport boundary while preserving current event delivery and unsubscribe behavior. Replace the old protocol guide with durable Agent Map API documentation and complete the retained-owner, deletion-revision and recovery record. This final stack branch contains all SAP-3089, SAP-3090 and SAP-3091 work for combined local validation.

Related work

Related issue or discussion: SAP-3091. Part of the authorized cleanup stack above #892 and #893, targeting main. The seven layers are intended to merge and ship together. Updated layers require maintainer approval before merge.

Validation

Review-fix verification on cumulative source 5bfed981, including current main (8679d745). Server and browser typechecks also passed on each of the seven isolated PR heads.

pnpm --filter '@sapiom/harness...' build — passed
pnpm --filter @sapiom/harness typecheck — passed
pnpm --filter @sapiom/harness lint — passed
pnpm --filter @sapiom/harness exec vitest run --maxWorkers=2 — 3,845 passed, 2 skipped
pnpm --filter @sapiom/harness test:perf — 10 passed
pnpm --filter @sapiom/harness exec playwright test --config <local Chrome override> --workers=2 — 634 passed
pnpm --filter @sapiom/harness exec playwright test --config <Canvas Chrome override> --workers=2 — 15 passed
pnpm terminology:check — passed
pnpm provider-copy:check — passed

The browser override selects the installed Google Chrome, temporary output paths and pnpm exec vite; it preserves the checked-in tests and assertions. All 16 focused map/style/project-tab cases passed, including light/dark computed styles, project/agent viewport restoration, offscreen recovery, automatic fitting, auth isolation and layout recovery. The viewport and metadata regressions failed before their fixes. The new viewport and project-altitude tests also passed on #907's own intermediate tree (10 cases).

An initial three-worker Harness run failed one archive-wiring case; the affected file passed unchanged 8/8, followed by the complete passing two-worker run above. The main integration passed 263 focused cases, and #892's resolved auth mock passed 4/4 on its own tree. No tests or admission guards were weakened.

All PR heads include main's deliberate removal of the duplicate Claude workflow in #886. The reviewed commits remain in history; the stack update uses ordinary fast-forward pushes. Fresh build hashes and the earlier package/smoke evidence are recorded in the retirement record. Signed macOS installer/upgrade validation remains SAP-3086.

Tests and documentation

Retained workspace/discovery/Canvas coverage and unsupported-event rejection tests. The retirement record separates the original deletion/package evidence from the new review-fix revision, build hashes and validation results.

Compatibility and release impact

  • Breaking or externally visible changes: No further public endpoint change beyond the preceding server layer. Unknown or retired events cannot enter browser state subscribers. Recovery requires reverting changes into strictly higher package and desktop release versions.
  • Changeset: N/A — the preceding server minor changeset covers the endpoint retirement; this layer deletes unreachable internals and updates its evidence.

Security

  • I have not included secrets, credentials, private data, or unsanitized logs.
  • This pull request does not publicly disclose a suspected vulnerability. I will follow the Security Policy for private reporting.

AI assistance

  • I did not use AI assistance for this change.
  • I used AI assistance and have described it below.

Codex implemented the cleanup and test/doc migrations, traced retained callers, and checked the resulting diffs. Automated checks above and independent read-only review provide implementation evidence; maintainer review is still required.

Checklist

  • I read CONTRIBUTING.md, and this contribution follows the direct-PR or issue-first policy.
  • This pull request addresses one focused problem and contains no unrelated cleanup.
  • I added or updated tests, or explained above why tests are not applicable.
  • I ran the relevant build, typecheck, lint, and test commands, or explained any N/A checks above.
  • I updated documentation for user-facing changes, or marked it N/A above.
  • I added a Changeset for a published-package change, or explained why it is not applicable.
  • I can explain and maintain every submitted change, including any AI-assisted work.

@ynadge
ynadge added this pull request to stack #894 September 9, 2026 23:28
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: cd5ee9f5-9fa8-41a2-aca9-d043bb1eaf88

📥 Commits

Reviewing files that changed from the base of the PR and between 5a1b979 and e1b8e23.

📒 Files selected for processing (29)
  • docs/plans/agent-studio-plan-first-agent-map/authority-retirement.md
  • docs/plans/agent-studio-plan-first-agent-map/retirement-verification.json
  • packages/harness/README.md
  • packages/harness/docs/agent-map-api.md
  • packages/harness/docs/workspace-system-graph.md
  • packages/harness/src/core/__fixtures__/system-graph-workspace/growth/index.ts
  • packages/harness/src/core/__fixtures__/system-graph-workspace/research/index.ts
  • packages/harness/src/core/canvas-interconnections.ts
  • packages/harness/src/core/system-graph-inventory.test.ts
  • packages/harness/src/core/system-graph-inventory.ts
  • packages/harness/src/core/system-graph-relationships.test.ts
  • packages/harness/src/core/system-graph-relationships.ts
  • packages/harness/src/core/system-graph-store.test.ts
  • packages/harness/src/core/system-graph-store.ts
  • packages/harness/src/core/system-graph-watcher.test.ts
  • packages/harness/src/core/system-graph-watcher.ts
  • packages/harness/src/core/system-graph.test.ts
  • packages/harness/src/core/system-graph.ts
  • packages/harness/src/server/events-ws.test.ts
  • packages/harness/src/server/system-graph.test.ts
  • packages/harness/src/server/system-graph.ts
  • packages/harness/src/shared/system-graph.ts
  • packages/harness/src/shared/types.ts
  • packages/harness/web/src/lib/bus-message-type.test.ts
  • packages/harness/web/src/lib/bus-message-type.ts
  • packages/harness/web/src/lib/events.test.ts
  • packages/harness/web/src/lib/events.ts
  • packages/harness/web/src/lib/use-harness-state.ts
  • scripts/agent-studio-terminology-allowlist.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ynadge
ynadge marked this pull request as ready for review September 10, 2026 03:33
gwitwer
gwitwer previously approved these changes Sep 10, 2026

@gwitwer gwitwer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. No dangling references anywhere in packages, docs, scripts or examples; public exports identical to main; the exhaustive event filter is typed against BusMessage so a variant mismatch fails typecheck. For the record: this deletes system-graph-inventory.ts and the slug-to-agent resolution in StaticSystemGraphBuilder.build. Nothing uses either today and both are in git history if the rebuild wants them back.

Keep the current auth isolation mock and carry the intentional removal of the duplicate Claude review workflow.

Refs: SAP-3089, SAP-3090, SAP-3091
Restore the browser contracts called out in review: remember manual pan and zoom per project for the current auth lifetime, retain automatic fitting, and cover sibling-agent project tabs.

Refs: SAP-3090
Preserve the muted monospace metadata role after removing the old graph styles. Cover the computed light and dark styles, attach mock-fixture before and after screenshots, and remove the stale mock failure comment.

Refs: SAP-3090
Describe the final authenticated 404 contract consistently across the combined release and document JSON responses for every unknown API path.

Refs: SAP-3091
Preserve the reviewed history while updating the stack for review fixes.
Keep original package evidence separate from current source and build results, including the initial archive test failure and unchanged passing reruns.

Refs: SAP-3089, SAP-3090, SAP-3091
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants