refactor(harness): delete retired server graph topology (SAP-3091) - #912
Conversation
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (29)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
gwitwer
left a comment
There was a problem hiding this comment.
Approving. No dangling references anywhere in packages, docs, scripts or examples; public exports identical to main; the exhaustive event filter is typed against BusMessage so a variant mismatch fails typecheck. For the record: this deletes system-graph-inventory.ts and the slug-to-agent resolution in StaticSystemGraphBuilder.build. Nothing uses either today and both are in git history if the rebuild wants them back.
Keep the current auth isolation mock and carry the intentional removal of the duplicate Claude review workflow. Refs: SAP-3089, SAP-3090, SAP-3091
Restore the browser contracts called out in review: remember manual pan and zoom per project for the current auth lifetime, retain automatic fitting, and cover sibling-agent project tabs. Refs: SAP-3090
Preserve the muted monospace metadata role after removing the old graph styles. Cover the computed light and dark styles, attach mock-fixture before and after screenshots, and remove the stale mock failure comment. Refs: SAP-3090
Describe the final authenticated 404 contract consistently across the combined release and document JSON responses for every unknown API path. Refs: SAP-3091
Preserve the reviewed history while updating the stack for review fixes.
Keep original package evidence separate from current source and build results, including the initial archive test failure and unchanged passing reruns. Refs: SAP-3089, SAP-3090, SAP-3091
Primary change type
Problem and motivation
The retired server graph engine, snapshot store, graph-only inventory/invocation lifecycle and contracts remained as orphaned source after composition removal.
Summary and scope
Delete those modules and their topology-only tests/fixtures. Remove the retired bus contract and filter unsupported events at the browser transport boundary while preserving current event delivery and unsubscribe behavior. Replace the old protocol guide with durable Agent Map API documentation and complete the retained-owner, deletion-revision and recovery record. This final stack branch contains all SAP-3089, SAP-3090 and SAP-3091 work for combined local validation.
Related work
Related issue or discussion: SAP-3091. Part of the authorized cleanup stack above #892 and #893, targeting
main. The seven layers are intended to merge and ship together. Updated layers require maintainer approval before merge.Validation
Review-fix verification on cumulative source
5bfed981, including currentmain(8679d745). Server and browser typechecks also passed on each of the seven isolated PR heads.The browser override selects the installed Google Chrome, temporary output paths and
pnpm exec vite; it preserves the checked-in tests and assertions. All 16 focused map/style/project-tab cases passed, including light/dark computed styles, project/agent viewport restoration, offscreen recovery, automatic fitting, auth isolation and layout recovery. The viewport and metadata regressions failed before their fixes. The new viewport and project-altitude tests also passed on #907's own intermediate tree (10 cases).An initial three-worker Harness run failed one archive-wiring case; the affected file passed unchanged 8/8, followed by the complete passing two-worker run above. The
mainintegration passed 263 focused cases, and #892's resolved auth mock passed 4/4 on its own tree. No tests or admission guards were weakened.All PR heads include
main's deliberate removal of the duplicate Claude workflow in #886. The reviewed commits remain in history; the stack update uses ordinary fast-forward pushes. Fresh build hashes and the earlier package/smoke evidence are recorded in the retirement record. Signed macOS installer/upgrade validation remains SAP-3086.Tests and documentation
Retained workspace/discovery/Canvas coverage and unsupported-event rejection tests. The retirement record separates the original deletion/package evidence from the new review-fix revision, build hashes and validation results.
Compatibility and release impact
Security
AI assistance
Codex implemented the cleanup and test/doc migrations, traced retained callers, and checked the resulting diffs. Automated checks above and independent read-only review provide implementation evidence; maintainer review is still required.
Checklist
CONTRIBUTING.md, and this contribution follows the direct-PR or issue-first policy.